bpo-37169: Rewrite _PyObject_IsFreed() unit tests#13888
Merged
Conversation
Replace two Python function calls with a single one to ensure that no memory allocation is done between the invalid object is created and when _PyObject_IsFreed() is called.
pablogsal
approved these changes
Jun 7, 2019
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
Why we have never seen this test fail?
Member
Author
No idea why https://bugs.python.org/issue37169 only fails on the openSUSE builder. It might depend on compiler optimizations like PGO or LTO? |
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Sorry @vstinner, I had trouble checking out the |
|
GH-13895 is a backport of this pull request to the 3.8 branch. |
vstinner
added a commit
that referenced
this pull request
Jun 7, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Replace two Python function calls with a single one to ensure that no memory allocation is done between the invalid object is created and when _PyObject_IsFreed() is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace two Python function calls with a single one to ensure that no
memory allocation is done between the invalid object is created and
when _PyObject_IsFreed() is called.
https://bugs.python.org/issue37169